feat(breadbox): Split out higher level functions into service layer #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creating datasets and dimension_types (matrix and tabular) went into service.datasets to avoid circular imports. Functions related to search went into service.search.
This is to avoid the confusion between dimension_types and data_types
They're old typing errors but due to virtue of renaming dimension_types.py they're no longer grandfathered in.
snwessel
approved these changes
Jan 15, 2025
| types.py: error: Cannot assign to attribute "dataset_id" for class "DimensionType" | ||
| types.py: error: Expression of type "IdMapping" is incompatible with declared type "Json[IdMappingInsanity] | None" | ||
| types.py: error: Expression of type "None" cannot be assigned to parameter of type "Dict[str, AnnotationType]" | ||
| types.py: error: No overloads for "rename" match the provided arguments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating datasets and dimension_types (matrix and tabular) went into service.datasets to avoid circular imports.
Functions related to search went into service.search.
Also renamed types.py to dimension_types.py to avoid the confusion between dimension_types and data_types