Components app #72
Merged
Components app #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yawaramin thank you for your feedback! |
It caused crash on resize, closes #44
wokalski
reviewed
Mar 7, 2019
rauanmayemir
force-pushed
the
components-app
branch
from
5ff398c to
912671c
Compare
wokalski
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add basic components app along with several improvements:
NSView,NSVisualEffectViewbindings and stylingNSScrollViewbindings and account for a Cocoa quirk when views are sticked to the bottom of scroll view if the height is less than clip view (i.e no scroll needed)Clickablecomponent to allow for making arbitrary areas clickable (also, drop all styling fromButton- it should be a System component)Viewtab showcasing View style propertiesWelcometab with a logo and some info