Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the comment describing the magic of updateOpaqueInstance #85

Merged
merged 4 commits into from
Nov 7, 2020

Conversation

glennsl
Copy link
Collaborator

@glennsl glennsl commented Nov 5, 2020

I'm not entirely confident that this is correct, so consider it more of a suggestion, but it should at least be more accurate than before!

@github-actions
Copy link

github-actions bot commented Nov 5, 2020

I have updated your lock dirs and formatted the code. Please @glennsl pull the last commit before pushing any more changes.

@glennsl
Copy link
Collaborator Author

glennsl commented Nov 5, 2020

I have updated your lock dirs and formatted the code. Please @glennsl pull the last commit before pushing any more changes.

Very good, sir. Thank you for your assistance.

Copy link
Member

@wokalski wokalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been much needed. I also added a small optional tweak to the explanation. Feel free to discard them.

lib/Brisk_reconciler_internal.re Show resolved Hide resolved
lib/Brisk_reconciler_internal.re Outdated Show resolved Hide resolved
Co-authored-by: Wojtek Czekalski <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 7, 2020

I have updated your lock dirs and formatted the code. Please @glennsl pull the last commit before pushing any more changes.

@wokalski wokalski merged commit 536458e into master Nov 7, 2020
@wokalski wokalski deleted the glennsl-patch-1 branch November 7, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants