Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ppxlib >=0.11.0 #76

Merged
merged 5 commits into from
Apr 5, 2020
Merged

Update to ppxlib >=0.11.0 #76

merged 5 commits into from
Apr 5, 2020

Conversation

wokalski
Copy link
Member

@wokalski wokalski commented Apr 4, 2020

Tested with 0.11.0 and 0.12.0

Fixes #73

I haven't thought about upper bounds or whether there's a more future-proof way of doing this with ppxlib.

@osener

Sorry, I messed something up

@wokalski
Copy link
Member Author

wokalski commented Apr 4, 2020

Could you check if the fix I pushed fixes your issue, too?

@ozanmakes
Copy link
Contributor

Works great, thanks for taking the time to get my PR right!

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

I have updated your lock dirs and formatted the code. Please @wokalski pull the last commit before pushing any more changes.

@github-actions
Copy link

github-actions bot commented Apr 5, 2020

I have updated your lock dirs and formatted the code. Please @wokalski pull the last commit before pushing any more changes.

@wokalski wokalski merged commit 10cab2d into master Apr 5, 2020
@wokalski wokalski deleted the osener-master branch April 5, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to ppxlib 0.9 to allow let-operators
2 participants
@wokalski @ozanmakes