Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the
ref
hook return an actualref
, removes the setter, and therefore acts, and has to be used, like an ordinary ref that persists across calls.The rationale for this change is that the name
ref
implies that the value 1) will be updated immediately, and 2) is a reference that will change its contents when updated elsewhere. Neither of which is true. It therefore acts like a bit of a trap which some people (i.e. me) fall into multiple times despite knowing how it actually works. An example is in revery-ui/revery#648. This change makes both of these implications true, while still fulfilling the role of the currentref
hook, but at the cost of using a slightly different API than both React and thestate
hook.