Add OnMountAndIf condition to effect hook #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsl
commented
Nov 7, 2019
lib/Hooks.re
Outdated
| ignore(executeOptionalHandler(cleanupHandler)); | ||
| executeOptionalHandler(cleanupHandler); |
There was a problem hiding this comment.
Luckily this had just been made unnecessary, but it might have been a bug if for example an argument had been added to cleanupHandler that resulted in a partial application. Especially in a call that is pure side-effect. To prevent bugs like that I always use let _: callback = ... or |> (ignore: callback => unit) instead of naked ignores or let _ = ....
And yes, this has actually bitten me before. It's not just theoretical 😁
wokalski
approved these changes
Jan 13, 2020
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Is this simple enough that you can verify it by eye, or do you want tests for certain conditions?
I added
OnMountAndIfinstead of "fixing"Ifsince this isn't a breaking change on the type level and therefore might lead to some very subtle bugs when upgrading.