Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ppxlib 0.9 to allow let-operators #73

Closed
lessp opened this issue Mar 7, 2020 · 2 comments · Fixed by #76
Closed

Update to ppxlib 0.9 to allow let-operators #73

lessp opened this issue Mar 7, 2020 · 2 comments · Fixed by #76

Comments

@lessp
Copy link

lessp commented Mar 7, 2020

Tried to just bump the dependency myself, but seems like there are some changes to the library itself so some type-errors popped out.

@lessp
Copy link
Author

lessp commented Mar 7, 2020

info esy 0.7.0-7b2976 (using package.json)
      ocamlc jsx/.brisk_ppx.objs/byte/brisk_ppx.{cmi,cmo,cmt} (exit 2)
(cd /Users/ter/dev/diverse/reason/brisk-reconciler/_esy/default/store/b/brisk_reconciler-aaafa5cc/default && /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.8.1000-426898cd/bin/ocamlc.opt -w -40 -w -9 -g -bin-annot -I jsx/.brisk_ppx.objs/byte -I /Users/ter/.esy/3_____________________________________________________________________/i/ocaml-4.8.1000-426898cd/lib/ocaml/compiler-libs -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__base-opam__c__v0.13.1-81726cfe/lib/base -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__base-opam__c__v0.13.1-81726cfe/lib/base/base_internalhash_types -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__base-opam__c__v0.13.1-81726cfe/lib/base/caml -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__base-opam__c__v0.13.1-81726cfe/lib/base/shadow_stdlib -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__ocaml_compiler_libs-opam__c__v0.12.1-670bfa9d/lib/ocaml-compiler-libs/common -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__ocaml_compiler_libs-opam__c__v0.12.1-670bfa9d/lib/ocaml-compiler-libs/shadow -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__ocaml_migrate_parsetree-opam__c__1.6.0-d7e7ef59/lib/ocaml-migrate-parsetree -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__ppx__derivers-opam__c__1.2.1-c84ca7ae/lib/ppx_derivers -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__ppxlib-opam__c__0.12.0-f26a7d1c/lib/ppxlib -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__ppxlib-opam__c__0.12.0-f26a7d1c/lib/ppxlib/ast -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__ppxlib-opam__c__0.12.0-f26a7d1c/lib/ppxlib/print_diff -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__ppxlib-opam__c__0.12.0-f26a7d1c/lib/ppxlib/traverse_builtins -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__result-opam__c__1.5-c94f3ce0/lib/result -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__sexplib0-opam__c__v0.13.0-fcf6d915/lib/sexplib0 -I /Users/ter/.esy/3_____________________________________________________________________/i/opam__s__stdio-opam__c__v0.13.0-6b3690d7/lib/stdio -no-alias-deps -o jsx/.brisk_ppx.objs/byte/brisk_ppx.cmo -c -impl jsx/brisk_ppx.pp.ml)
File "jsx/brisk_ppx.ml", line 54, characters 46-66:
54 |     | P.Pexp_apply (fn, args) when exists_jsx expr.pexp_attributes ->
                                                   ^^^^^^^^^^^^^^^^^^^^
Error: This expression has type P.attributes = P.attribute list
       but an expression was expected of type (String.t AT.loc * 'a) list
       Type P.attribute = Parsetree.attribute is not compatible with type
         String.t AT.loc * 'a 
error: command failed: 'dune' 'build' '-p' 'brisk-reconciler' (exited with 1)
esy-build-package: exiting with errors above...
error: build failed with exit code: 1
  
esy: exiting due to errors above

@wokalski
Copy link
Member

wokalski commented Mar 7, 2020

I see. what a surprise, direct pattern matching on AST causing problems 😂

@lessp lessp closed this as completed Mar 8, 2020
@lessp lessp reopened this Mar 8, 2020
ozanmakes added a commit to ozanmakes/brisk-reconciler that referenced this issue Apr 4, 2020
Tested with 0.11.0 and 0.12.0

Fixes briskml#73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants