Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase concurrent blob and recipe downloads from registry #172

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kylewlacy
Copy link
Member

Related to #147

Pretty self-explanatory: this PR bumps the total number of concurrent blob downloads from 10 to 200, and the total number of concurrent recipe downloads from 25 to 200.

I tested this in the packages repo from 4f8fd12 with this patch applied:

diff --git a/packages/std/toolchain/native/index.bri b/packages/std/toolchain/native/index.bri
index 174c2dc..6e814b9 100644
--- a/packages/std/toolchain/native/index.bri
+++ b/packages/std/toolchain/native/index.bri
@@ -440,6 +440,7 @@ function makePkgConfigPathsRelative(
 function syncTarball(
   recipe: std.AsyncRecipe<std.Directory>,
 ): std.Recipe<std.Directory> {
+  return std.recipe(recipe);
   recipe = std.collectReferences(std.directory({ recipe }));
 
   const tarredRecipe = std

Here's the total build times I got before and after this PR, starting with a totally empty Brioche dir each time:

Total build time
Before 7m 9s
After 1m35s

@kylewlacy
Copy link
Member Author

I'm opening this as a draft because I'd definitely want to do testing with values besides just 200 blobs / 200 recipes concurrently. Plus, I have some ideas for a larger change that might make this PR irrelevant, but nothing ready to test yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant