Simplify deployment by removing the need for any env vars by default #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vieiralucas
changed the title
vieiralucas
force-pushed
the
single-port
branch
from
af1b5d4 to
bca9e68
Compare
vieiralucas
commented
Sep 13, 2024
Comment on lines
+93
to
+94
| API_URL: '/api' | ||
| FRONTEND_URL: '/' |
There was a problem hiding this comment.
Maybe these should be the default?
If the user wants to deploy the api and web in different domain then it needs to specify that
What do you think? @lucasfcosta
If we make these values default, we can simplify the deployment docs by just omitting these variables and leave this detail for people that want to do a more advanced deployment.
vieiralucas
force-pushed
the
single-port
branch
from
bca9e68 to
f7c9a53
Compare
vieiralucas
force-pushed
the
single-port
branch
from
f7c9a53 to
8194528
Compare
|
Closes #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lucasfcosta can you review and improve the docs?
I made some changes there but maybe now we can write it differently.