-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor security fixes and test updates #55
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Deploying medici-typedoc with
|
Latest commit: |
a46e596
|
Status: | ✅ Deploy successful! |
Preview URL: | https://a82865d7.medici-typedoc.pages.dev |
Branch Preview URL: | https://macha-security-fixes.medici-typedoc.pages.dev |
* allow transfers for non policy attached assets and update tests * use self hosted * add more tests
minor security fixes and test updates (#55)
This PR fixes the following security issues:
execute
function now includesinstructions_program
, which is used to fetch the relevant instruction that is CPI'ing to theexecute
function. This ensures that unauthorized users cannot callexecute
and increase tracker account metrics.data_account
update instruction now includes a constraint to ensure thedata_account
belongs to thedata_registry
being used in the instruction.registry/engine
create instructions now include a signer account with a constraint check to ensure the mint authority is signing.programs/policy_engine/src/instructions/engine/delegate.rs
instruction.