-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): check cognitive services restrict outbound network #6919
Merged
tjwald
merged 6 commits into
main
from
check/coginitive-services-restrict-network-access
Dec 23, 2024
Merged
feat(terraform): check cognitive services restrict outbound network #6919
tjwald
merged 6 commits into
main
from
check/coginitive-services-restrict-network-access
Dec 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo156
approved these changes
Dec 22, 2024
checkov/terraform/checks/resource/azure/CognitiveServicesRestrictOutboundNetwork.py
Outdated
Show resolved
Hide resolved
tsmithv11
previously requested changes
Dec 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Small title change suggestion
checkov/terraform/checks/resource/azure/CognitiveServicesRestrictOutboundNetwork.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/azure/CognitiveServicesRestrictOutboundNetwork.py
Outdated
Show resolved
Hide resolved
SteveVaknin
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 💯
…ictOutboundNetwork.py Co-authored-by: Taylor <[email protected]>
34ad3b6
to
6dfc801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Implemented a check for open ai cognitive services in azure to make sure outbound network is restricted.
Implements Prisma Policy Id :"4c4ae367-8609-4b55-ac11-e9d52849658a"
New/Edited policies (Delete if not relevant)
id = "CKV_AZURE_247"
name = "Ensure that Azure Cognitive Services account hosted with OpenAI is configured with data loss prevention"
Description
Check that the cognitive service is either restricted to no access to outbound network, or is restricted to specific fqdns.
Fix
Either set
outbound_network_access_restricted = true
, orfqdns = [...]
.Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Implements a new check for Azure Cognitive Services accounts hosted with OpenAI to ensure data loss prevention. Adds a new class
OpenAICognitiveServicesRestrictOutboundNetwork
that checks if the outbound network access is restricted or if specific FQDNs are set. Creates test cases to verify the functionality of the new check, including both passing and failing scenarios.Modified files (2)
Latest Contributors(0)
Modified files (1)
Latest Contributors(0)