fix(secrets): masking test format #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matansha
temporarily deployed
to
scan-security
GitHub Actions
Inactive
matansha
changed the title
omryMen
had a problem deploying
to
scan-security
GitHub Actions
Failure
matansha
force-pushed
the
fix_test_masking
branch
from
84c9c8f to
d533a36
Compare
matansha
had a problem deploying
to
scan-security
GitHub Actions
Failure
matansha
temporarily deployed
to
scan-security
GitHub Actions
Inactive
omryMen
approved these changes
Nov 21, 2024
achiar99
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Refactor the JSON structure in the
tests/secrets/masking_secretsdirectory to improve readability and maintainability. The changes involve restructuring the JSON objects inassets_report_with_pass.jsonandfindings_report_with_pass.jsonby removing redundant fields and simplifying the nested structures. This update aims to enhance the clarity of the data representation, particularly focusing on theaws_instance.web_hostresource, which is used for testing secret masking in Terraform configurations.assets_report_with_pass.jsonby removing redundant fields and restructuring nested objects for better readability and maintainability.Modified files (1)
Latest Contributors(1)
findings_report_with_pass.jsonto streamline the JSON structure, focusing on theaws_instance.web_hostresource, and remove unnecessary fields to enhance clarity.Modified files (1)
Latest Contributors(1)