Updated IndexedDB Adapter #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Hey, Paul: I've got some outstanding fixes for IndexedDB as well in cscott/lawnchair@573d5ed971 (my indexeddb-wip branch) although I've kinda forgotten why some of the patches are there. I was trying to make something which worked in both Firefox and Webkit, which is a tough road to hoe for IndexedDB (sigh). IIRC (I've paged out a bit of state since when I wrote the patches) Firefox was having issues with version upgrades still. I'm going to try to merge your work and mine to get these fixes upstream... but if I flake, feel free to steal anything you like from my patch set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to the spec has 'readwrite', 'readonly' and 'versionchange' instead of the enumerations for the transaction types, implemented in Chrome 21.
Also fixed a change to behaviour that no other transactions can be triggered when a 'versionchange' event is in process. Simply moved the transactions to complete handler for the 'versionchange' event rather than being called inside the setVersion onsuccess callback.