Sort multiple run bugs #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to also use them outside of object.cu (mostly during `generate_main`) and hence need them as class attributes. We now use `varname` instead of `var` for variables on host, since this allows checking for them in `generate_main`.
This reverts commit 367cf3e.
We were allocating new queues at each run and thereby loosing all spikes from the previous run. Now we only allocate when needed and make sure the spikes are not lost.
The number of eventspaces is always one more than time steps in scalar delay.
Mostly fixing synapse generation leaks. There still seems to be a memory leak. Not sure if that still comes from the synapse initialisation or maybe from somewhere else (e.g. static variables in each codeobject file?)
This was referenced Jun 22, 2022
If there are more than 1024 delays, we still call `prepare()` with only one block, hence we use a loop. Adapted the assert.
This reverts commit ea32da8. The number of eventspaces is determined by all synaptic pathways from the associated neurongroup, hence it can't be simplified!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #83 and #86.
Follow-up issues are in #301 and #302