Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-asset send/receive #645

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Multi-asset send/receive #645

merged 3 commits into from
Jan 24, 2025

Conversation

dangeross
Copy link
Collaborator

@dangeross dangeross commented Jan 7, 2025 •
edited
Loading

This PR:

  • adds support to send/receive non Liquid Bitcoin assets
  • adds asset balances to the get_info response
  • lists and filters non Liquid Bitcoin payments

Testing Notes:

@dangeross dangeross force-pushed the savage-multi-assets branch from 417f0e4 to 8e447d0 Compare January 7, 2025 20:57
hydra-yse
hydra-yse reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@hydra-yse hydra-yse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @roeierez Nice work Ross, looks elegant and simple! Just left some comments, we can discuss the ones related to product decisions with the others

lib/core/src/persist/migrations.rs Outdated Show resolved Hide resolved
lib/bindings/src/breez_sdk_liquid.udl Outdated Show resolved Hide resolved
lib/core/src/model.rs Outdated Show resolved Hide resolved
@dangeross dangeross force-pushed the savage-multi-assets branch from 97daac6 to 2ece61c Compare January 8, 2025 10:21
@dangeross dangeross marked this pull request as ready for review January 8, 2025 10:42
@dangeross dangeross force-pushed the savage-multi-assets branch from 9e4a051 to 5cb8e58 Compare January 8, 2025 12:11
@dangeross dangeross changed the base branch from main to savage-payment-expiry January 8, 2025 12:11
danielgranhao
danielgranhao reviewed Jan 8, 2025
View reviewed changes
cli/src/commands.rs Outdated Show resolved Hide resolved
cli/src/commands.rs Outdated Show resolved Hide resolved
lib/bindings/src/breez_sdk_liquid.udl Show resolved Hide resolved
lib/bindings/src/breez_sdk_liquid.udl Show resolved Hide resolved
lib/bindings/src/breez_sdk_liquid.udl Show resolved Hide resolved
lib/bindings/src/breez_sdk_liquid.udl Outdated Show resolved Hide resolved
lib/core/src/persist/mod.rs Outdated Show resolved Hide resolved
lib/core/src/wallet.rs Show resolved Hide resolved
lib/core/src/sdk.rs Outdated Show resolved Hide resolved
roeierez
roeierez requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

lib/core/src/persist/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sdk.rs Outdated Show resolved Hide resolved
lib/core/src/sdk.rs Outdated Show resolved Hide resolved
@dangeross dangeross force-pushed the savage-multi-assets branch from 5cdbf49 to 7f338e7 Compare January 8, 2025 14:27
@roeierez roeierez added this to the Next Release milestone Jan 9, 2025
@dangeross dangeross force-pushed the savage-multi-assets branch from dafa38d to 94c4308 Compare January 13, 2025 08:41
@dangeross dangeross changed the base branch from savage-payment-expiry to main January 13, 2025 08:41
roeierez
roeierez approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hydra-yse hydra-yse mentioned this pull request Jan 14, 2025
Merged
@dangeross dangeross force-pushed the savage-multi-assets branch 4 times, most recently from c49919a to 01d77f8 Compare January 14, 2025 15:38
@dangeross dangeross mentioned this pull request Jan 14, 2025
Merged
4 tasks
@dangeross dangeross force-pushed the savage-multi-assets branch 3 times, most recently from 289d61f to 4dfef3b Compare January 20, 2025 09:15
@roeierez roeierez modified the milestones: Next Release, v0.7.0 Jan 20, 2025
hydra-yse
hydra-yse approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@hydra-yse hydra-yse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danielgranhao
danielgranhao reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@danielgranhao danielgranhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some very minor nits and a comment about supporting regtest.

lib/core/src/persist/migrations.rs Show resolved Hide resolved
lib/core/src/sdk.rs Outdated Show resolved Hide resolved
lib/core/src/sdk.rs Outdated Show resolved Hide resolved
lib/core/src/sdk.rs Outdated Show resolved Hide resolved
@dangeross dangeross force-pushed the savage-multi-assets branch from b75822a to b066c8b Compare January 24, 2025 08:48
@dangeross dangeross force-pushed the savage-multi-assets branch from b066c8b to 8707492 Compare January 24, 2025 10:44
@dangeross dangeross merged commit e196a91 into main Jan 24, 2025
9 checks passed
@dangeross dangeross deleted the savage-multi-assets branch January 24, 2025 15:55
@dangeross dangeross mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez roeierez approved these changes

@danielgranhao danielgranhao danielgranhao approved these changes

@hydra-yse hydra-yse hydra-yse approved these changes

Assignees
No one assigned
Labels
Testing Verified
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dangeross @roeierez @danielgranhao @hydra-yse @Nackoo2000