Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various CI fixes #162

Merged
merged 5 commits into from
May 6, 2024
Merged

Various CI fixes #162

merged 5 commits into from
May 6, 2024

Conversation

dangeross
Copy link
Collaborator

@dangeross dangeross commented May 3, 2024

This PR fixes:

  • android bindings compile compatibility
  • kotlin multiplatform lib directories
  • swift repo default branch
  • publish order of React Native with Swift dependency

@dangeross dangeross requested review from roeierez and ok300 May 3, 2024 16:49
# - setup
# - build-language-bindings
# - publish-swift
# if: ${{ needs.setup.outputs.swift == 'true' && needs.setup.outputs.flutter == 'true' }}
Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift bindings aren't needed at all with frb v2, as well as build-language-bindings & publish-swift steps.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the Flutter change

Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangeross dangeross merged commit 612e2dd into main May 6, 2024
5 checks passed
@dangeross dangeross deleted the savage-ci-fixes branch May 6, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants