-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Check Dart/Flutter bindings & run static code analysis for Dart/Flutter packages #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemyerebasmaz
force-pushed
the
flutter_ci
branch
from
May 3, 2024 14:34
3be9b09
to
e4025b6
Compare
erdemyerebasmaz
changed the title
CI: Check Dart/Flutter bindings & run static code analysis for Dart/Flutter packages
[Draft] CI: Check Dart/Flutter bindings & run static code analysis for Dart/Flutter packages
May 3, 2024
erdemyerebasmaz
force-pushed
the
flutter_ci
branch
4 times, most recently
from
May 5, 2024 09:46
2ab2c43
to
fd298a6
Compare
erdemyerebasmaz
changed the title
[Draft] CI: Check Dart/Flutter bindings & run static code analysis for Dart/Flutter packages
CI: Check Dart/Flutter bindings & run static code analysis for Dart/Flutter packages
May 5, 2024
- Add static analysis step for Dart & Flutter packages - Ignore warning for unused element on build scrips for Windows targets - Continue if there are any errors with generating bindings
Remove symlink files from version control
ok300
approved these changes
May 6, 2024
erdemyerebasmaz
force-pushed
the
flutter_ci
branch
from
May 6, 2024 08:37
79a5069
to
e9a9154
Compare
Recent changes:
|
- Rename 'all' to 'bootstrap' - Add 'frb' parameter to install 'frb' dependencies - Disable test-flutter recipe - Do not build library again child recipes of 'test'
erdemyerebasmaz
force-pushed
the
flutter_ci
branch
from
May 6, 2024 11:50
804c871
to
222c2a6
Compare
Update README accordingly - Remove Melos from prerequisites
Update dependencies to latest & increase the supported range
erdemyerebasmaz
force-pushed
the
flutter_ci
branch
from
May 6, 2024 12:00
222c2a6
to
0568929
Compare
dangeross
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI workflows for pull requests will be
with this PR.
Other changes:
just all
recipe(command) that bundles the whole process 55e1103ffigen
and there are no options to exclude files fromdart format
, which conflicted with checking formatting differences step on CI.A workaround will be addressed on a separate PR as it'll involve folder restructuring & explicit format commands for all packages & melos scripts.
flutter_rust_bridge
to version2.0.0-dev.33
">=2.0.0-dev.0 <=2.0.0-dev.33"
Known issues:
flutter_rust_bridge_codegen generate
emits a SEVERE error which should be ignored. This issue will be reported on frb repository.Addressed by continuing if there are any errors when generating bindings.