Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename workspace members (subfolders) #149

Merged
merged 3 commits into from
May 2, 2024
Merged

Rename workspace members (subfolders) #149

merged 3 commits into from
May 2, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented May 2, 2024

@dangeross
Copy link
Collaborator

Is there any issue with it being sdk-bindings like Breez SDK? It's a bit shorter

@ok300 ok300 force-pushed the ok300-rename-lib-folders branch from 25e853f to cdd2f7d Compare May 2, 2024 15:50
@ok300
Copy link
Contributor Author

ok300 commented May 2, 2024

Yes just realised that. How about just bindings since its the root folder of all bindings?

@ok300 ok300 requested a review from dangeross May 2, 2024 16:20
@ok300 ok300 changed the title [Draft] Rename ls-sdk-bindings workspace member Rename ls-sdk-bindings workspace member May 2, 2024
@ok300 ok300 mentioned this pull request May 2, 2024
Closed
7 tasks
@ok300 ok300 changed the title Rename ls-sdk-bindings workspace member Rename workspace members (subfolders) May 2, 2024
dangeross
dangeross approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ok300 ok300 merged commit 6589a87 into main May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangeross dangeross dangeross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ok300 @dangeross