Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go/CS bindings #147

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Add Go/CS bindings #147

merged 3 commits into from
Aug 28, 2024

Conversation

dangeross
Copy link
Collaborator

@dangeross dangeross commented May 2, 2024 •
edited
Loading

Unfortunately testing of uniffi-bindgen-go v0.2.1+v0.25.0 with uniffi 0.27 fails. Currently the only way to include Go is to use uniffi 0.25 with uniffi-bindgen-go v0.2.1+v0.25.0

@dangeross dangeross force-pushed the savage-go-bindings branch 4 times, most recently from 4110b1f to dc252a0 Compare May 2, 2024 16:08
ok300
ok300 reviewed May 2, 2024
View reviewed changes
lib/Cargo.toml Show resolved Hide resolved
@dangeross dangeross force-pushed the savage-go-bindings branch from d365e47 to bf3b794 Compare May 3, 2024 09:35
erdemyerebasmaz
erdemyerebasmaz reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question regarding dependency requirement

lib/Cargo.toml Show resolved Hide resolved
@dangeross dangeross force-pushed the savage-go-bindings branch 8 times, most recently from d9a67a7 to cb8fe82 Compare May 6, 2024 20:04
@dangeross
Copy link
Collaborator Author

dangeross commented May 6, 2024 •
edited
Loading

Publishing runs successfully: https://github.com/breez/breez-liquid-sdk-go

But for this to be merged:

  • Change targets for uniffi 0.25 breez-sdk-liquid-swift#2 - to bump the macOS/iOS versions to v15/v13 for Package.swift and podspec files. This change only effects uniffi 0.25, when eventually 0.27 can be used we can revert back to v12/v11
  • Other bindings need to be retested using uniffi 0.25

@dangeross dangeross changed the title [Draft] Add Go bindings Add Go bindings May 13, 2024
@dangeross dangeross force-pushed the savage-go-bindings branch 2 times, most recently from 9f14aa1 to 74e5645 Compare May 21, 2024 07:02
@dangeross dangeross changed the base branch from main to savage-rename-bindings-dirs May 21, 2024 07:04
@dangeross dangeross force-pushed the savage-rename-bindings-dirs branch from 74e5645 to cc7a6ef Compare May 21, 2024 12:42
Base automatically changed from savage-rename-bindings-dirs to main May 21, 2024 13:20
@dangeross dangeross force-pushed the savage-go-bindings branch from eb87ca9 to 3165710 Compare May 21, 2024 15:39
@dangeross dangeross force-pushed the savage-go-bindings branch from 3165710 to 89f0ba8 Compare June 3, 2024 10:58
@dangeross dangeross force-pushed the savage-go-bindings branch from 89f0ba8 to e314450 Compare June 18, 2024 09:33
@dangeross dangeross force-pushed the savage-go-bindings branch 2 times, most recently from 487d70f to 294f414 Compare July 10, 2024 12:19
@dangeross dangeross changed the title Add Go bindings Add Go/CS bindings Jul 10, 2024
@dangeross dangeross merged commit 251c252 into main Aug 28, 2024
6 of 7 checks passed
@dangeross dangeross deleted the savage-go-bindings branch August 28, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ok300 ok300 ok300 left review comments

@erdemyerebasmaz erdemyerebasmaz erdemyerebasmaz left review comments

@roeierez roeierez roeierez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dangeross @erdemyerebasmaz @roeierez @ok300