-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frb] : Add support for Dart/Flutter bindings - Part II #121
Conversation
454ffe5
to
db2e984
Compare
db2e984
to
1c23e8c
Compare
@ok300 @dangeross Rebased & applied all the renaming/folder structure changes then generated bindings. Please take another look. Ross has suggested moving If we move the whole directory under packages, we'll have Dart & Flutter package live under:
which I find non-ideal. If making a folder & package name distinction is compatible with build scripts, I'll move build scripts elsewhere and generate the libraries under:
on a separate PR. |
2d98fcb
to
b8dbe41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few NITs about the project renaming
- a few instances of
ls_sdk.*
files - a few instances of
breez-sdk-liquid
instead ofbreez-liquid-sdk
Might be worth to do a full search-replace to make sure all occurrences are covered.
lib/flutter/packages/flutter_breez_liquid/android/CMakeLists.txt
Outdated
Show resolved
Hide resolved
lib/flutter/packages/flutter_breez_liquid/macos/Classes/ls_sdk.h
Outdated
Show resolved
Hide resolved
lib/flutter/packages/flutter_breez_liquid/macos/flutter_breez_liquid.podspec
Outdated
Show resolved
Hide resolved
lib/flutter/packages/flutter_breez_liquid/windows/CMakeLists.txt
Outdated
Show resolved
Hide resolved
I agree
looks cleaner, if it's possible to achieve in a separate PR. |
Thanks, I believe everything is covered now.
Yes, I plan to handle it on a separate PR. Current folder structure is made compatible with changes in #130 |
- lib is required for non-library targets, such as tests and benchmarks - staticlib is required for iOS - cdylib for all other platforms
- Enable full dependencies
Add comments on profile settings
Saves ~30 seconds & binary size is reduced by 50%
- breez_sdk_liquid -> breez_liquid_sdk - Fix repository hyperlinks - Change descriptions on Dart/Flutter packages
cd2716d
to
71c42b0
Compare
Closes #9
This PR adds Dart/Flutter packages their build tools & generates Dart bindings.
There's a lot of boilerplate code, to ease review process I'd suggest you to go over these scripts:
PR TODO:
Other changelist:
min
profile forls-sdk-flutter
scripts 6691553crate-types
are configured for target devices 66f6886[ls-sdk-bindings]
UseLsSdkError
fromls-sdk::error
57d1d0cTODO: