in-page translation #2006
in-page translation #2006
Conversation
yrliou
force-pushed
the
page-translate
branch
3 times, most recently
from
f07daee to
5f54528
Compare
yrliou
force-pushed
the
page-translate
branch
3 times, most recently
from
dd87208 to
c456ea9
Compare
browser/net/brave_translate_redirect_network_delegate_helper.cc
Outdated
Show resolved
Hide resolved
|
Updated wording in the bubble title, now looks like this: |
The language here looks good. |
|
rebased on C74. |
| @@ -396,6 +396,10 @@ By installing this extension, you are agreeing to the Google Widevine Terms of U | |||
| <message name="IDS_SETTINGS_BRAVE_ON_EXIT" desc="Clear Browsing Data dialog On exit tab label"> | |||
| On exit | |||
| </message> | |||
| <!-- In-page Translation --> | |||
| <message name="IDS_BRAVE_TRANSLATE_BUBBLE_BEFORE_TRANSLATE_TITLE" desc="Title text for the translate bubble when asking to translate a page."> | |||
| Translate this page? This will send all text on this page to Microsoft for translation. | |||
There was a problem hiding this comment.
Do we plan to have a wiki that highlights the text will not be associated with any user identifiable information?
There was a problem hiding this comment.
not yet; maybe https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs could mention what data is sent in each of the proxied requests
Revert "use chromium_src override instead" This reverts commit d872ce8.
…be sent to the MS server.
1. Fix typo 2. Use constant in system network delegate 3. Use BindRepeating instead of Bind
|
linux and mac passed: https://staging.ci.brave.com/job/brave-browser-build-pr/job/page-translate/3/flowGraphTable/ @emerick sorry the review is being dismissed again because I have to push again to try windows after reverting widevine PRs, no code changes here, please approve again then I'll merge. |
|
🎉 |
|
Great job with this, @yrliou! And thanks for being vigilant to make CI passes 😄 |
|
Sorry, this is not working on MacOS 10.14.5 going to www.yandex.ru - it never shows the translate bubble. Doesn't have Translate in the context menu either. Neither does going to the specified verification webpage (deutschland.de/de) - if it is going to be difficult to enable, it isn't working in my book. This is with Brave Version 0.65.118 Chromium: 75.0.3770.80 (Official Build) (64-bit).
|
|
@kmichelizzi Translation service is disabled on Release channel currently due to cost performance, we're still working on enabling it on Release channel. |
|
Thanks, @yrliou - the Nightly, Dev, and Beta don't run on MacOS 10.14.5. All 3 versions just spin until crash on loading. |
|
@kmichelizzi I'm also on MacOS 10.14.5, Nightly, Dev, and Beta all works fine for me. |
Fix brave/brave-browser#208
This PR re-enable entries of translate service, all incurred requests will be sent to go-translate server (https://github.com/brave/go-translate) to either be relayed to MS server or be proxied through Brave to avoid introducing direct connections to google.
go-translate is now running locally at localhost:8195 manually, the URL will be updated to a brave server once go-translate is deployed by devops.
Related PR:
brave/go-translate#1
Entry points of translation service
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Navigate to https://www.deutschland.de/de and click translate when the translate bubble shows up. Continue surfing through this website and pages should be translated.
Open a new tab to navigate to https://www.deutschland.de/de, click "Translate to English" (depends on your local language) in the context menu, current page should be translated, when click away through links in this page, they will not be translated.
Reviewer Checklist: