New feature: Favorite cards #369
Conversation
fixed test checkMenu bug
There was a problem hiding this comment.
Please note that I am not the owner of this project, so my opinion has less value than that of @brarcher, but I figured I would chime in anyway.
I also want to state that I'm missing tests for this starring functionality.
I do think the idea of the future itself is great though and I'm pretty sure I'll use it myself a lot too! Just the code could do with some cleaning up :)
Please note that @brarcher is currently on hiatus so it may take longer to get his opinion on this. I am willing to help you with parts of your pull request if you need any help. Thank you for making this :)
app/src/androidTest/java/protect/card_locker/ApplicationTest.java
Outdated
Show resolved
Hide resolved
app/src/test/java/protect/card_locker/LoyaltyCardViewActivityTest.java
Outdated
Show resolved
Hide resolved
corrected CsvDatabaseImporter bugs Signed-off-by: t351206 <[email protected]>
"starred" renamed to starStatus for better readability Signed-off-by: t351206 <[email protected]>
Signed-off-by: t351206 <[email protected]>
Signed-off-by: t351206 <[email protected]>
|
|
I would like to see the following tests:
I think that should cover things |
Signed-off-by: t351206 <[email protected]>
Signed-off-by: t351206 <[email protected]>
Signed-off-by: t351206 <[email protected]>
|
@TheLastProject : Thanks for the test proposals! ad 1) I think I need some help here. |
|
How can I test clicking on the star? shadowOf(activity).clickMenuItem(R.id.action_star_unstar) is producing an exception: |
LoyaltyCardViewActivity adapted (onPrepareOptionsMenu used) Signed-off-by: t351206 <[email protected]>
Signed-off-by: t351206 <[email protected]>
|
@TheLastProject: I think I solved the testing issue! Test "checkPushStarIcon" is working as expected! |
|
Sorry I didn't get back to you in your last reply, things have been a bit chaotic here and I forgot. Let me build your branch and play around with it a bit on my phone :) |
|
Have a few more comments but the code seems to work quite well and I do like it a lot :) |
typo corrected Signed-off-by: t351206 <[email protected]>
tests adapted content description for star image added Signed-off-by: t351206 <[email protected]>
Signed-off-by: t351206 <[email protected]>
Signed-off-by: t351206 <[email protected]>
There was a problem hiding this comment.
Well, I am happy with it now. Let's hope @brarcher finds some time soon to take a look at this too :)
|
Hi @t351206, After talking with @brarcher I ended up forking Loyalty Card Locker. I would love to include your feature in my fork (which I will soon publish after I have a new icon). Could you please make this pull request on https://github.com/TheLastProject/Catima? |
Description (this is a follow-up to #305 ):
If you have some favorite loyalty cards it is useful to have them as first items in the listview. Therefore I added the "star-unstar" feature. Cards in the LoyaltyCardViewActivity can be be starred in order to make them a favorite card.
Therefore a new SQLite table column was added where the starring status is saved.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
[email protected]