Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels for Python 2.7 again #263

Merged
merged 6 commits into from
Oct 6, 2024
Merged

Build wheels for Python 2.7 again #263

merged 6 commits into from
Oct 6, 2024

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Oct 9, 2023

No description provided.

@cdce8p cdce8p mentioned this pull request Oct 9, 2023
@cdce8p
Copy link
Contributor Author

cdce8p commented Dec 2, 2023

@brandon-rhodes You mentioned a while ago that you originally wanted to keep publishing wheels for 2.7. This PR would do that and could be merged as is if you like.

@brandon-rhodes
Copy link
Owner

@cdce8p — Yes, thank you for this pull request! It has been an open tab over on the left side of my browser for a few weeks, during which I've had other projects demanding my attention — but I'm planning to merge as soon as my attention can be turned back to PyEphem, probably by the end of the year!

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 6, 2024

Requires #278 to be merged first.

@brandon-rhodes
Copy link
Owner

I just did the merge, so you should be able to go ahead and rebase! Thanks for making this pull request active again; it fell off my radar during a busy winter and, obviously, I hadn't yet returned to it.

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 6, 2024

I just did the merge, so you should be able to go ahead and rebase! Thanks for making this pull request active again; it fell off my radar during a busy winter and, obviously, I hadn't yet returned to it.

It's all working now. I needed to fall back to macos-13 as macos-latest uses the M1 chip and is not compatible with Python 2.7.

Also added a small changelog entry for the Python 3.13 support. With that you should be able to just merge it into release afterwards.

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 6, 2024

Checks are all green. This is ready now 🚀

@brandon-rhodes
Copy link
Owner

One quick question before we merge: do the checks that ran on this PR test whether the github-deploy.yml actions will run successfully? Or, will they receive their first-and-only test after merging, when I advance the release branch to include this commit?

(And, if they haven't run yet in this PR: should we adjust things so that those actions run here, though without the credentials they would need to do a real upload to PyPI?)

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 6, 2024

One quick question before we merge: do the checks that ran on this PR test whether the github-deploy.yml actions will run successfully? Or, will they receive their first-and-only test after merging, when I advance the release branch to include this commit?

I've been testing the workflow on my fork (with a modified trigger to run on push). So I'm quite confident that it will work. The only slight unknown is the pypa/gh-action-pypi-publish@release/v1 action as I couldn't test that. However, the upload with API key should continue to work even if Trusted publishing is the recommended option nowadays.

(And, if they haven't run yet in this PR: should we adjust things so that those actions run here, though without the credentials they would need to do a real upload to PyPI?)

That would be an option although I'm not sure it's fully necessary. Especially the build_wheels job (in the deploy workflow) takes quite a while. So we would need some kind of limited setup and mostly end up where we're now anyways. The breaking change for the artifact actions was the most tricky to work out, but hopefully that won't be repeated anytime soon.

@brandon-rhodes
Copy link
Owner

I've been testing the workflow on my fork…

Good! Thank you for the reassurance. As soon as the new slate of tests passes, I'll plan to merge and the advance the release branch and see if new versions appear on PyPI or not.

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 6, 2024

I've been testing the workflow on my fork…

Good! Thank you for the reassurance. As soon as the new slate of tests passes, I'll plan to merge and the advance the release branch and see if new versions appear on PyPI or not.

Awesome, thanks! Sorry about the multiple commits btw. I pushed the last one only after reading #256.

@brandon-rhodes brandon-rhodes merged commit d356c8e into brandon-rhodes:master Oct 6, 2024
5 checks passed
@cdce8p cdce8p deleted the build-wheels-py27 branch October 6, 2024 17:30
@brandon-rhodes
Copy link
Owner

IT WORKED! I see Python 2.7 and 3.13 builds now listed on PyPI!

Thanks so much for putting this together. 🙂

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 6, 2024

IT WORKED! I see Python 2.7 and 3.13 builds now listed on PyPI!

Thanks so much for putting this together. 🙂

Awesome 🚀

Would you mind creating the 4.1.6 tag on Github?
https://github.com/brandon-rhodes/pyephem/tags

@brandon-rhodes
Copy link
Owner

Would you mind creating the 4.1.6 tag on Github?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants