-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build wheels for Python 2.7 again #263
Build wheels for Python 2.7 again #263
Conversation
@brandon-rhodes You mentioned a while ago that you originally wanted to keep publishing wheels for |
@cdce8p — Yes, thank you for this pull request! It has been an open tab over on the left side of my browser for a few weeks, during which I've had other projects demanding my attention — but I'm planning to merge as soon as my attention can be turned back to PyEphem, probably by the end of the year! |
Requires #278 to be merged first. |
I just did the merge, so you should be able to go ahead and rebase! Thanks for making this pull request active again; it fell off my radar during a busy winter and, obviously, I hadn't yet returned to it. |
It's all working now. I needed to fall back to Also added a small changelog entry for the Python 3.13 support. With that you should be able to just merge it into |
Checks are all green. This is ready now 🚀 |
One quick question before we merge: do the checks that ran on this PR test whether the (And, if they haven't run yet in this PR: should we adjust things so that those actions run here, though without the credentials they would need to do a real upload to PyPI?) |
I've been testing the workflow on my fork (with a modified trigger to run on push). So I'm quite confident that it will work. The only slight unknown is the
That would be an option although I'm not sure it's fully necessary. Especially the |
Good! Thank you for the reassurance. As soon as the new slate of tests passes, I'll plan to merge and the advance the |
Awesome, thanks! Sorry about the multiple commits btw. I pushed the last one only after reading #256. |
IT WORKED! I see Python 2.7 and 3.13 builds now listed on PyPI! Thanks so much for putting this together. 🙂 |
Awesome 🚀 Would you mind creating the |
Done. |
No description provided.