Fix issue with scrolling after closing dialog #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malinicz
requested review from
krzotki,
Fasosnql and
radekwarisch
as code owners
matzimowski
approved these changes
Dec 5, 2024
krzotki
approved these changes
Dec 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS didn't show this as error because
scrollYis a global variable 🙈Problem: wrong
scrollYvalue was set in the cleanup function (current one instead of initial), which resulted in scrolling to the top after closing Dialog.Before:
Screen.Recording.2024-12-05.at.12.32.48.mov
After:
Screen.Recording.2024-12-05.at.12.29.54.mov