feat(gene-next): routing - handle start and error in $routeChanged observable #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzimowski
changed the title
matzimowski
changed the title
matzimowski
force-pushed
the
(gene-next)---routing---handle-start-and-error-in-$routeChanged-observable
branch
from
dbfc1b8 to
000fa49
Compare
krzotki
approved these changes
Feb 11, 2025
matzimowski
deleted the
(gene-next)---routing---handle-start-and-error-in-$routeChanged-observable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
$routeChangednotifies only about changed route, there was no info if this change already started (so it's in progress) or an error happened.payload.currentPathnamereturns wrong valueChanges
payload.currentPathname- it used to return the first char of the path string, instead of the whole pathrouteChangeStartandrouteChangeErrorrouter events