test: fix gene-tools tests #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopach
commented
Jan 2, 2025
Comment on lines
-223
to
-229
| "export { useCreateQuestion } from './lib/useCreateQuestion';" | ||
| ); | ||
| expect(indexFile).not.toContain( | ||
| "export { useDeleteQuestion } from './lib/useDeleteQuestion';" | ||
| ); | ||
| expect(indexFile).toContain( | ||
| "export { useUpdateQuestion } from './lib/useUpdateQuestion';" |
There was a problem hiding this comment.
based on expectations from above (see line 200). those should not be here
| expect(indexFile).toContain( | ||
| "export { useUpdateQuestion } from './lib/useUpdateQuestion';" | ||
| ); | ||
| expect(indexFile).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
looks like those nothing more that snapshost tests, so updated. This way it's easier to manage those in case of formatting change
kopach
force-pushed
the
deps/upgrade-NX-fix-tests
branch
from
8cd00d9 to
224a008
Compare
krzotki
approved these changes
Jan 2, 2025
kopach
force-pushed
the
deps/upgrade-NX-fix-tests
branch
from
224a008 to
44b49bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.