[RF] refactor ezBIDS core #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to improve how imaging data is detected. Currently, when DICOM files aren't present, we reply on the existence of the JSON metadata files (either provided by
dcm2niix, other software, or manually created) for detecting imaging data. This approach should be inverted, where we check for the existence of the actual image files (i.e. NIfTI). Furthermore, the BIDS specification doesn't require metadata for all datatypes, such asanatsequences. Even under scenarios where there are no corresponding JSON metadata files yet specific metadata is required, our recent metadata support guides users to provide this information.This PR will therefore be most relevant in situations where only NIfTI files are provided, a not entirely uncommon case.