Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kwargs params to Render.screenshot() and Render.export() #368

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

carlocastoldi
Copy link
Contributor

option added to tweak camera and zoom parameters when exporting a non-rendered scene

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.13%. Comparing base (570cecd) to head (f8ef5a3).

Files Patch % Lines
brainrender/render.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   86.98%   88.13%   +1.15%     
==========================================
  Files          27       27              
  Lines        1214     1214              
==========================================
+ Hits         1056     1070      +14     
+ Misses        158      144      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson adamltyson requested a review from a team June 17, 2024 10:11
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlocastoldi - looks good to me.

@alessandrofelder alessandrofelder merged commit 2b9e895 into brainglobe:main Jun 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants