Remove unused camera printing code and make camera parameters consistent #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamltyson
changed the title
|
FYI the tests are failing because of the neuromorpho issue, but also because of an issue that's fixed, but not yet released in vedo. |
alessandrofelder
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing #360 I noticed that the camera parameters that brainrender checks don't exactly match the parameters that the user that it must have. This corrects that.
I then noticed that the code that prints the camera position isn't actually used (vedo uses the same keyboard shortcut), so I removed it. I raised marcomusy/vedo#1134 to correct the parameters that are printed.