Remove SpikeData #87
Merged
Remove SpikeData #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
atspaeth
force-pushed
the
remove-spikedata
branch
from
76e2cf9 to
4698401
Compare
|
@atspaeth Is this ready for review? I haven't checked this PR in a while, and I don't want to lose your work on this. |
atspaeth
force-pushed
the
remove-spikedata
branch
from
4230061 to
fc99f90
Compare
atspaeth
force-pushed
the
remove-spikedata
branch
from
fc99f90 to
0d1240c
Compare
|
@DailyDreaming Yep! Just rebased. It's only the first step of the migration plan I had in mind, so this doesn't change the interface at all. It just gets the SpikeData object from this package now: https://github.com/braingeneers/SpikeData (and doesn't bother testing it because that package has its own tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on refactoring out the SpikeData class and all the related analysis into a package called spikedata, then re-exporting it through braingeneers.analysis. The idea is to eventually deprecate braingeneers.analysis entirely (the new package will transparently replace it) and move the data loaders back into datasets.
So far this obviously isn't ready to merge, since the new package is only published via GitHub, not PyPI, but I wanted to make the work on this visible and have a place to discuss design stuff.