Patch up the MEArec reader. #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrenmm
approved these changes
Oct 24, 2023
| data_files = [] | ||
| for root, dirs, files in os.walk(path): | ||
| for name in files: | ||
| if name.endswith('.h5') or name.endswith('.hdf5'): |
There was a problem hiding this comment.
Is there any risk of a index mismatch if this "if" condition fails? There is no "else" condition to complain or throw an error, so it might be hard to see where it went wrong if this if condition returns false.
davidparks21
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some bugs and hopefully this addresses some of them (specifically local files were not being read when ENDPOINT was set, and
load_data()was set to the intan function accidentally, instead of MEArec).