Fixed minor issues with travis scripts and a typo with automerge workflow #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvfairchild
approved these changes
Nov 29, 2023
Updates `travis.yml` file to use Pyhton3.9 instead of 3.6 in the "Automerge check" job. Using Python 3.6 causes dependency issues with BSL's requirement for `setuptools` version and the ones available in PyPI for Python 3.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with the current auto-merging pipeline:
.github/workflows/automerge_plugin-only_prs.yml. The term$github.event.pull_request.head.sha/check-runs\does not get evaluated in the current script, so I replaced it with${{ github.event.pull_request.head.sha }}.scriptblock in the last job in Travis overrides the top-levelscriptblock, so$PLUGIN_ONLYwill always beFalseas defined in theenvblock. This PR fixes this by copying the script that evaluates$PLUGIN_ONLYto thescriptblock of the last Travis job.