Clean up and centralize submission pipeline in core
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschrimpf
approved these changes
Oct 12, 2023
kvfairchild
added a commit
that referenced
this pull request
Oct 15, 2023
…(s) (#205) * if PR ONLY changes plugin files, ONLY run tests for respective plugin(s) * typo * typo * more typos. github mobile app fail. * test core output * retest core output * retest core output * add build directory for getting changed files * git fetch main for diff check * test git diff in travis.yml * pass changed files to parse_plugin_changes() * convert changed files to string * distinguish between plugin only and modifies (any) plugin * testing * testing * testing * testing * cleanup * cleanup * only invoke automerge if plugin_only * only invoke automerge if plugin_only * Clean up and centralize submission pipeline in `core` (#207) * move submission logic from github actions into travis/core * plugin_info -> output * send_user_email() -> UserManager * point core to relevant branch --------- Co-authored-by: Katherine Fairchild <[email protected]> * testing_needed -> get_testing_info * add requests * replace changed files action with git diff * point core to main * point core to main * typo --------- Co-authored-by: Katherine Fairchild <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with core PR #43, cleans up and consolidates submission logic out of domain repos and into core.
Reviewer note: yes @mschrimpf, I will point the core dependency back to
mainonce core #43 is merged. 😆