-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Updates Israeli bank scrapers library #537
Build: Updates Israeli bank scrapers library #537
Conversation
I tested the workflow on a different repository because I suspect that workflows cannot be executed on forked repositories on GitHub. Additionally, it's necessary to enable the option in the repository settings under Actions settings that allows the bot to create new pull requests automatically for the workflow to function properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
See my comments.
To allow this workflow you (and @brafdlog) must enable it in the settings:
https://github.com/peter-evans/create-pull-request/tree/v6?tab=readme-ov-file#workflow-permissions
Other option is to work with a draft PR, customise this workflow to work on PR, change the israeli-bank-scraper version and I will aprrove it to run on your PR, just to check it. It is OK for me.
Thanks @ronnahmias! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I temporarily changed your code to test it on the current branch.
As you can see here, the pipeline didn't stop when there was no upgrade.
I have mentioned this that I didn't find proper way to stop it without an error on the workflow but the create pr will not open new pr so I don't think there is issue to continue with steps. |
…hub.com/ronnahmias/caspion into feature/update-israeli-scrapers-library
OK then, I will accept it if it passes without errors and without doing anything. |
I have added base branch master It need to be work. I cannot test on this repo I have tested on other repo and It works. Also I have remove the log of the manual running and the checks of the if condition between old and new versions variables. Let me know if you need other changes |
Hi I have seen that there is no permission to action to make pr |
@ronnahmias I'm trying to figure it. Did you say it worked on your fork? Did you manage to generate a PR on your fork? |
This reverts commit 5cc9781.
It worked on my fork, I guess it is related to the PR token and so, I will merge it. |
# [1.22.0](v1.21.0...v1.22.0) (2024-02-21) ### Build * Updates Israeli bank scrapers library (#537) ([b816ea3](b816ea3)), closes [#537](#537) [#536](#536) ### Upgrade * Bump ip from 1.1.5 to 1.1.9 in /nuxt (#540) ([3a18220](3a18220)), closes [#540](#540) * Bump ip from 1.1.8 to 1.1.9 in /ui-react (#539) ([ead6335](ead6335)), closes [#539](#539)
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
New Feature #536