Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Updates Israeli bank scrapers library #537

Merged

Conversation

ronnahmias
Copy link
Contributor

@ronnahmias ronnahmias commented Feb 19, 2024

New Feature #536

@ronnahmias
Copy link
Contributor Author

I tested the workflow on a different repository because I suspect that workflows cannot be executed on forked repositories on GitHub. Additionally, it's necessary to enable the option in the repository settings under Actions settings that allows the bot to create new pull requests automatically for the workflow to function properly.

Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

See my comments.

To allow this workflow you (and @brafdlog) must enable it in the settings:
https://github.com/peter-evans/create-pull-request/tree/v6?tab=readme-ov-file#workflow-permissions

Other option is to work with a draft PR, customise this workflow to work on PR, change the israeli-bank-scraper version and I will aprrove it to run on your PR, just to check it. It is OK for me.

@baruchiro baruchiro changed the title New: Updates Israeli bank scrapers library CI: Updates Israeli bank scrapers library Feb 20, 2024
@brafdlog
Copy link
Owner

Thanks @ronnahmias!

This setting is already enabled for our repo:
Uploading IMG_3213.jpeg…

@baruchiro baruchiro linked an issue Feb 20, 2024 that may be closed by this pull request
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I temporarily changed your code to test it on the current branch.

As you can see here, the pipeline didn't stop when there was no upgrade.

@ronnahmias
Copy link
Contributor Author

I temporarily changed your code to test it on the current branch.

As you can see here, the pipeline didn't stop when there was no upgrade.

I have mentioned this that I didn't find proper way to stop it without an error on the workflow but the create pr will not open new pr so I don't think there is issue to continue with steps.

@baruchiro
Copy link
Collaborator

I have mentioned this that I didn't find proper way to stop it without an error on the workflow but the create pr will not open new pr so I don't think there is issue to continue with steps.

OK then, I will accept it if it passes without errors and without doing anything.
For now, the Create PR action is failing, don't know why:
https://github.com/brafdlog/caspion/actions/runs/7973297488/job/21767795314?pr=537#step:10:43

@ronnahmias
Copy link
Contributor Author

I have mentioned this that I didn't find proper way to stop it without an error on the workflow but the create pr will not open new pr so I don't think there is issue to continue with steps.

OK then, I will accept it if it passes without errors and without doing anything. For now, the Create PR action is failing, don't know why: https://github.com/brafdlog/caspion/actions/runs/7973297488/job/21767795314?pr=537#step:10:43

I have added base branch master It need to be work. I cannot test on this repo I have tested on other repo and It works. Also I have remove the log of the manual running and the checks of the if condition between old and new versions variables.

Let me know if you need other changes

@ronnahmias
Copy link
Contributor Author

ronnahmias commented Feb 21, 2024

Hi I have seen that there is no permission to action to make pr
https://github.com/brafdlog/caspion/actions/runs/7974876278/job/21771772695

@baruchiro
Copy link
Collaborator

@ronnahmias I'm trying to figure it. Did you say it worked on your fork? Did you manage to generate a PR on your fork?

@baruchiro baruchiro changed the title CI: Updates Israeli bank scrapers library Build: Updates Israeli bank scrapers library Feb 21, 2024
This reverts commit 5cc9781.
@baruchiro
Copy link
Collaborator

It worked on my fork, I guess it is related to the PR token and so, I will merge it.

@baruchiro baruchiro merged commit b816ea3 into brafdlog:master Feb 21, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
# [1.22.0](v1.21.0...v1.22.0) (2024-02-21)

### Build

* Updates Israeli bank scrapers library (#537) ([b816ea3](b816ea3)), closes [#537](#537) [#536](#536)

### Upgrade

* Bump ip from 1.1.5 to 1.1.9 in /nuxt (#540) ([3a18220](3a18220)), closes [#540](#540)
* Bump ip from 1.1.8 to 1.1.9 in /ui-react (#539) ([ead6335](ead6335)), closes [#539](#539)
Copy link
Contributor

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically create a PR for israeli-bank-scrapers upgrades
3 participants