TFO

bradh352 · Aug 1, 2024 · a4fff0d · a4fff0d
1 parent bd0a394
commit a4fff0d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/alpine-latest.yml b/.github/workflows/alpine-latest.yml
@@ -19,6 +19,7 @@ jobs:
     runs-on: ubuntu-latest
     container:
       image: alpine:latest
+# Needed for TCP FastOpen
       options: --privileged
     name: "Alpine (latest)"
     steps:
@@ -27,7 +28,6 @@ jobs:
           apk add bash cmake samurai gtest-dev autoconf autoconf-archive automake libtool pkgconf make clang17 clang17-analyzer compiler-rt lldb gcc g++ valgrind gdb sudo
       - name: Checkout c-ares
         uses: actions/checkout@v4
-# This will fails in a container...
       - name: "Make sure TCP FastOpen is enabled"
         run: |
           sudo sysctl -w net.ipv4.tcp_fastopen=3
@@ -101,13 +101,14 @@ jobs:
         run: |
           ./ci/build.sh
           ./ci/test.sh
-      - name: "Valgrind: build and test c-ares"
+      - name: "Valgrind: build and test c-ares (no TCP FastOpen)"
         env:
           BUILD_TYPE: "valgrind"
           TEST_WRAP: "valgrind --leak-check=full"
           TEST_FILTER: "--gtest_filter=-*Container*:*LiveSearchANY*:*LiveSearchTXT*"
           CMAKE_TEST_FLAGS: "-DCARES_BUILD_TESTS=ON"
           TEST_DEBUGGER: none
         run: |
+          sudo sysctl -w net.ipv4.tcp_fastopen=3
           ./ci/build.sh
           ./ci/test.sh
diff --git a/.github/workflows/ubuntu-2004.yml b/.github/workflows/ubuntu-2004.yml
@@ -19,6 +19,7 @@ jobs:
     runs-on: ubuntu-latest
     container:
       image: ubuntu:20.04
+# Needed for TCP FastOpen
       options: --privileged
     name: "Ubuntu 20.04"
     steps:
@@ -31,7 +32,6 @@ jobs:
           apt-get install -y --assume-yes sudo curl wget cmake ninja-build autoconf automake libtool g++ libgmock-dev pkg-config clang clang-tools lldb gdb valgrind
       - name: Checkout c-ares
         uses: actions/checkout@v4
-# This will probably fail in a container...
       - name: "Make sure TCP FastOpen is enabled"
         run: |
           sudo sysctl -w net.ipv4.tcp_fastopen=3