feat(space-tool): add/remove space locally when pressing shift #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
force-pushed
the
local-space-tool
branch
from
cea67d9 to
650d4ef
Compare
bpmn-io-tasks
bot
added
needs review
nikku
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Looks great! Integration testing this I found only one issue that I believe cannot reasonably be fixed in diagram-js:
The fact that lanes are "hover-ignored" in bpmn-js, so they do not become drop targets. They should not be space resize targets either, I think.
Thanks for pointing out. We will fix that as part of the integration into bpmn-js. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be tried out via
npx @bpmn-io/sr bpmn-io/bpmn-js#develop -l bpmn-io/diagram-js#local-space-tool.Related to bpmn-io/bpmn-js#557