fixed sharing URL resolver for not available URLs #2828

bpampuch · Jan 3, 2025 · feb4afe · feb4afe
1 parent 9974c93
commit feb4afe
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Fixed URL resolving for same URL in browser
+- Fixed sharing URL resolver for not available URLs
 
 ## 0.3.0-beta.15 - 2025-01-01
 

diff --git a/src/base.js b/src/base.js
@@ -18,7 +18,7 @@ class pdfmake {
 		options.progressCallback = this.progressCallback;
 		options.tableLayouts = this.tableLayouts;
 
-		let printer = new Printer(this.fonts, this.virtualfs, this.urlResolver);
+		let printer = new Printer(this.fonts, this.virtualfs, this.urlResolver());
 		const pdfDocumentPromise = printer.createPdfKitDocument(docDefinition, options);
 
 		return this._transformToDocument(pdfDocumentPromise);

diff --git a/src/browser-extensions/index.js b/src/browser-extensions/index.js
@@ -21,7 +21,7 @@ let defaultClientFonts = {
 class pdfmake extends pdfmakeBase {
 	constructor() {
 		super();
-		this.urlResolver = new URLBrowserResolver(this.virtualfs);
+		this.urlResolver = () => new URLBrowserResolver(this.virtualfs);
 		this.fonts = defaultClientFonts;
 	}
 

diff --git a/src/index.js b/src/index.js
@@ -5,7 +5,7 @@ const URLResolver = require('./URLResolver').default;
 class pdfmake extends pdfmakeBase {
 	constructor() {
 		super();
-		this.urlResolver = new URLResolver(this.virtualfs);
+		this.urlResolver = () => new URLResolver(this.virtualfs);
 	}
 
 	_transformToDocument(doc) {