Chapter 11: Account activation #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
boummm
commented
Apr 12, 2019
boummm
commented
|
ready |
boummm
force-pushed
the
chapter_11
branch
2 times, most recently
from
9326864 to
0387595
Compare
yanghoxom
reviewed
Apr 12, 2019
| @@ -0,0 +1,2 @@ | |||
| // Place all the behaviors and hooks related to the matching controller here. | |||
There was a problem hiding this comment.
k dùng thì xoá, để cmt cái này hơi nhiều
| class AccountActivationsController < ApplicationController | ||
| def edit | ||
| user = User.find_by email: params[:email] | ||
| if user && !user.activated? && user.authenticated?(:activation, params[:id]) |
There was a problem hiding this comment.
anh chưa chỉ chú cách dùng user&.method à ???
There was a problem hiding this comment.
ban đầu em chạy rubocop nó tự chỉnh cho rồi mà bh up lên lại về như cũ :<
|
|
||
| def active user | ||
| user.activate | ||
| user.update_attributes activated: true, activated_at: Time.zone.now |
There was a problem hiding this comment.
sử dụng Time.current nhé
nêu giúp anh sự khác biệt vs hiện tại nếu có
There was a problem hiding this comment.
em pull lên không hiểu sao nó bị về như cũ :(((
Time.zone được khởi chạy bởi ActiveSupport::Railtie thông qua active_support.initialize_time_zone nên nếu t xóa active_support.initialize_time_zone đi thì sẽ bị hiển thị thành nil trong khi Time.current vẫn ổn
| end | ||
|
|
||
| def password_reset | ||
| @greeting = t("hi") |
| def password_reset | ||
| @greeting = t("hi") | ||
|
|
||
| mail to: "[email protected]" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.