-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
window: Port to modern widgets #3674
Draft
TheEvilSkeleton
wants to merge
12
commits into
bottlesdevs:main
Choose a base branch
from
TheEvilSkeleton:rework-window
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+377
−428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheEvilSkeleton
force-pushed
the
rework-window
branch
7 times, most recently
from
January 10, 2025 13:42
d011316
to
5181a12
Compare
TheEvilSkeleton
force-pushed
the
rework-window
branch
from
January 14, 2025 03:39
5181a12
to
9630a4f
Compare
TheEvilSkeleton
force-pushed
the
rework-window
branch
2 times, most recently
from
January 17, 2025 00:17
d1e7703
to
c9b2412
Compare
GtkStack is more suitable for switching pages.
This ports GtkHeaderBar to AdwHeaderBar, makes full use of AdwToolbarView, and ports AdwViewSwitcherTitle to AdwViewSwitcher.
This lets us to clamp the search bar to a maximum size, allowing us to have a wider yet natural width.
TheEvilSkeleton
force-pushed
the
rework-window
branch
from
January 17, 2025 00:46
c9b2412
to
8efee0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3562
Depends on #3691