Replace bottle view entry with bottle row #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheEvilSkeleton
force-pushed
the
replace-bottle-view-entry-with-bottle-row
branch
3 times, most recently
from
2a37108 to
5e6642c
Compare
GNOME apps typically use the app icon in the status page.
It makes more sense and is more explanatory.
This also gets rid of all the weird callbacks with `GLib.idle_add()` and other methods.
TheEvilSkeleton
force-pushed
the
replace-bottle-view-entry-with-bottle-row
branch
from
5e6642c to
7f488a5
Compare
It's best to keep IDs accessible.
mirkobrombin
approved these changes
Dec 28, 2024
TheEvilSkeleton
deleted the
replace-bottle-view-entry-with-bottle-row
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the old
BottleViewEntrywidget with a new, more efficient and lighter,BottlesBottleRowwidget, which follows the same convention as GTK and libadwaita (prefixed namespace). It also cleans up a good chunk of the code.