Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FileDialog for all file/path pickers #3554

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

penguinpee
Copy link
Contributor

  • Use FileDialog throughout
  • Handle whatever GLib.Error throws our way
  • Handle it the same way regardless of dialog

@penguinpee
Copy link
Contributor Author

Gtk.FileChooserNative causes a segfault in GTK_IS_FILE_SYSTEM_MODEL when launching the Working Directory dialog (__choose_cwd()).

This aligns __choose_cwd() with __choose_pre_script() and __choose_post_script().

@TheEvilSkeleton
Copy link
Member

Is it okay for you run pre-commit run --all-files and squash these commits? If not, I can do it

@penguinpee
Copy link
Contributor Author

I don't have pre-commit set up.

However, I could squash locally and (force) push to my PR branch, if that helps.

@TheEvilSkeleton
Copy link
Member

Don't worry, I'll squash and run pre-commit against it ^^

Copy link
Member

@TheEvilSkeleton TheEvilSkeleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution :)

@TheEvilSkeleton TheEvilSkeleton merged commit 5fd0a76 into bottlesdevs:main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants