Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamescope: flag changes #3262

Closed
wants to merge 2 commits into from
Closed

Gamescope: flag changes #3262

wants to merge 2 commits into from

Conversation

svin24
Copy link

@svin24 svin24 commented Jan 25, 2024

Description

Gamescope recently changed a few flags.
Notably FSR and integer scaling(at least that is what I assume the -n flag meant according to the bottles UI)

ValveSoftware/gamescope@7a1fe2d

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Tried running software with gamescope and integer scaling turned on in the settings
  • Tried running software with gamescope and FSR

Additional info

Terminal outputs of the issue:

gamescope-brokey: invalid option -- 'U'
See --help for a list of options.
gamescope-brokey: invalid option -- 'n'
See --help for a list of options.

Apparently this is also changed to -S integer. I assume that this is the intention due to what the existing bottles UI says. Not sure when the change happened.
Copy link

fab-sonarqube bot commented Jan 25, 2024

@koplo199
Copy link
Contributor

Fixes already included in #3217

@svin24
Copy link
Author

svin24 commented Jan 26, 2024

@koplo199 ah I see, very well then closing this, since it is not needed.

@svin24 svin24 closed this Jan 26, 2024
@svin24 svin24 mentioned this pull request Jan 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants