-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add account ID to static credentials providers #3348
base: account-id-endpoint-routing
Are you sure you want to change the base?
Add account ID to static credentials providers #3348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## account-id-endpoint-routing #3348 +/- ##
==============================================================
Coverage ? 93.17%
==============================================================
Files ? 66
Lines ? 14437
Branches ? 0
==============================================================
Hits ? 13452
Misses ? 985
Partials ? 0 ☔ View full report in Codecov by Sentry. |
I think these changes look good. The only thing I'd suggest is adding a test that verifies the correct precedence for |
This PR introduces account ID to
SharedCredentialProvider
andConfigProvider
. The update allows users to specify anaws_account_id
variable either in the shared credentials file, config file, or during client creation. The account ID will then be associated with the credentials when they are loaded.