Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the new LinkAnnotation APIs #64

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Conversation

boswelja
Copy link
Owner

@boswelja boswelja commented Dec 22, 2024

This is a minor breaking change! Instead of providing an onLinkClick: (String) -> Unit, you now provide onLinkClick: (LinkAnnotations) -> Unit.

You'll need to do a

when (linkAnnotation) {
  LinkAnnotation.Url -> {
    handle(linkAnnotation.url)
  }
}

To handle the same cases as before.

Also updated all dependencies and verified no performance regressions

@boswelja boswelja changed the title Update dependencies Migrate to the new LinkAnnotation APIs Dec 22, 2024
@boswelja boswelja self-assigned this Dec 22, 2024
@boswelja boswelja merged commit 182108e into main Dec 22, 2024
8 checks passed
@boswelja boswelja deleted the update-dependencies branch December 22, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant