Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update code with redesign of commit widget and other updates from core components #1122

Merged

Conversation

albertfolch-redeemeum
Copy link
Contributor

@albertfolch-redeemeum albertfolch-redeemeum commented Jan 13, 2025

  • change colors as we had many colors too similar (to check delta use https://colordesigner.io/compare-colors):
    lightGrey2 (eff0f7) => greyLight (F1F3F9) (delta 0.97)
    darkGreyTimeStamp (E8EAF1) => greyLight (F1F3F9) (delta 1.68)
    lightArrowColor (dedfe3) => greyLight2 (dedfe3) (delta 0)
    grey3 (A1A1A1) => greyLight4 (A1A1A1) (delta 0) => new color in CC (back again actually)

This PR also upgrade the dApp in order to support BASE networks, added in core-components (fixes #1124 )

@albertfolch-redeemeum albertfolch-redeemeum changed the title wip: pending to update CTAs in commit widget update with roblox and redesign of commit widget Jan 13, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 13, 2025

Deploying interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: e6467cb
Status: ✅  Deploy successful!
Preview URL: https://cf2f9e7a.interface-a9d.pages.dev
Branch Preview URL: https://update-with-roblox-and-redes.interface-a9d.pages.dev

View logs

@albertfolch-redeemeum albertfolch-redeemeum marked this pull request as ready for review January 24, 2025 15:00
@albertfolch-redeemeum albertfolch-redeemeum requested a review from a team as a code owner January 24, 2025 15:00
@albertfolch-redeemeum albertfolch-redeemeum changed the title update with roblox and redesign of commit widget feat: update code with redesign of commit widget and other updates from core components Jan 24, 2025
@albertfolch-redeemeum
Copy link
Contributor Author

albertfolch-redeemeum commented Jan 24, 2025

some copies still need to be changed, for example @sukrita3 , the modal you see after sending a commit transaction:

Commit transaction submitted

You have successfully committed!

Comment on lines -418 to +437
"0x52eF3d68BaB452a294342DC3e5f464d7f610f72E",
[ChainId_POLYGON_AMOY]: new Token(
ChainId_POLYGON_AMOY,
"0x778f1b662a461695633791d03a77d992c24b588a",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this address change intended?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no official Wrapped MATIC contract on Amoy. However 0x52eF3d68BaB452a294342DC3e5f464d7f610f72E is not Wrapped MATIC, but Wrapped ETH on Amoy (also added in the same file, line 202), so I've changed it to avoid any confusion
I think this has no consequence

@albertfolch-redeemeum albertfolch-redeemeum merged commit 3090ca5 into main Jan 28, 2025
11 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the update-with-roblox-and-redesign-commit-widget branch January 28, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for Base network
2 participants