Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preview of new products for new sellers #1078

Conversation

albertfolch-redeemeum
Copy link
Contributor

@albertfolch-redeemeum albertfolch-redeemeum commented Apr 30, 2024

the preview was not available because it was crashing, now it doesnt crash

I also fixed some styled components warnings

Copy link

cloudflare-workers-and-pages bot commented Apr 30, 2024

Deploying interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: 172e194
Status: ✅  Deploy successful!
Preview URL: https://917c8766.interface-a9d.pages.dev
Branch Preview URL: https://1075-preview-of-a-product-be.interface-a9d.pages.dev

View logs

Comment on lines +92 to +105
if (!offer.seller) {
return (
<>
<Loading />
<BosonButton
variant="accentInverted"
type="button"
onClick={handleClosePreview}
>
Back to overview
</BosonButton>
</>
);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of the fix

Comment on lines +455 to +456
const { seller: currentAssistant, lens: lensProfiles } =
useWaitForCreatedSeller();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of the fix

@albertfolch-redeemeum albertfolch-redeemeum marked this pull request as ready for review April 30, 2024 16:08
@albertfolch-redeemeum albertfolch-redeemeum requested a review from a team as a code owner April 30, 2024 16:08
Copy link
Member

@levalleux-ludo levalleux-ludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertfolch-redeemeum albertfolch-redeemeum merged commit a895d74 into main May 2, 2024
9 checks passed
@albertfolch-redeemeum albertfolch-redeemeum deleted the 1075-preview-of-a-product-being-created-breaks-when-you-create-a-new-seller-but-works-if-you-refresh-and-try-again branch May 2, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants