Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100 consider highest pure runout level #109

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

old2rng
Copy link
Contributor

@old2rng old2rng commented Sep 27, 2024

@old2rng old2rng self-assigned this Sep 27, 2024
@old2rng old2rng linked an issue Sep 27, 2024 that may be closed by this pull request
@old2rng
Copy link
Contributor Author

old2rng commented Sep 27, 2024

I think I made a mistake. It should be merged to main... Sorry!

@johannes-mueller johannes-mueller changed the base branch from develop to master September 27, 2024 11:17
Copy link
Member

@johannes-mueller johannes-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. Please consider the comments in the code

tests/materialdata/woehler/test_analyzer.py Outdated Show resolved Hide resolved
tests/materialdata/woehler/test_analyzer.py Outdated Show resolved Hide resolved
tests/materialdata/woehler/test_analyzer.py Outdated Show resolved Hide resolved
src/pylife/materialdata/woehler/fatigue_data.py Outdated Show resolved Hide resolved
src/pylife/materialdata/woehler/fatigue_data.py Outdated Show resolved Hide resolved
Signed-off-by: Johannes Mueller <[email protected]>
@johannes-mueller johannes-mueller force-pushed the 100-consider-highest-pure-runout-level branch from a1a8a9a to 36fc5ad Compare October 1, 2024 15:23
Copy link
Member

@johannes-mueller johannes-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Rebased to fix the DCO check.

@johannes-mueller johannes-mueller merged commit 1d65dcc into master Oct 1, 2024
12 checks passed
@johannes-mueller johannes-mueller deleted the 100-consider-highest-pure-runout-level branch October 1, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wöhler analyzer must only consider highest pure run out level
2 participants