Ap 294 epic convert adyen payment methods #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' of github.com:bortefi/adyen-shopware5 into AP-279-store-ayden-payment-methods-as-shopware-payments
bortefi
commented
Sep 22, 2021
|
|
||
| class RemoveStoredPaymentsSubscriber implements SubscriberInterface | ||
| { | ||
| public static function getSubscribedEvents(): array | ||
| { | ||
| return [ | ||
| 'Enlight_Controller_Action_PostDispatchSecure_Backend_Payment' => '__invoke' | ||
| 'Enlight_Controller_Action_PostDispatchSecure_Backend_Payment' => 'providePaymentsWithAdyenHideFunctionality' |
There was a problem hiding this comment.
better to keep invoke here and rename the namespace or the class
|
|
||
| if ($adyenSourceType !== (string) $paymentMethod['source']) { | ||
| continue; | ||
| if ((true === $paymentMethod['hide'] |
There was a problem hiding this comment.
Any reason why this is a combined if?
With early returns / continue the functionality is more clear upon reading the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Pull request Do NOT MERGE