-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: borg commands updated with --repo option #8681
base: master
Are you sure you want to change the base?
Conversation
Guess you also need to apply some other of your fixes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8681 +/- ##
==========================================
- Coverage 81.83% 81.82% -0.02%
==========================================
Files 74 74
Lines 13319 13348 +29
Branches 1963 1971 +8
==========================================
+ Hits 10900 10922 +22
- Misses 1755 1761 +6
- Partials 664 665 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I've updated the pull request with the non-autoupdated rst files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some stuff i found.
@@ -329,14 +329,14 @@ Reading backup data from stdin | |||
There are two methods to read from stdin. Either specify ``-`` as path and | |||
pipe directly to borg:: | |||
|
|||
backup-vm --id myvm --stdout | borg create REPO::ARCHIVE - | |||
backup-vm --id myvm --stdout | borg create --repo REPO ARCHIVE - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a auto-generated file, you need to edit the respective .py file to change contents here.
see comment in line 1 of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you see my comment?
src/borg/archiver/create_cmd.py
Outdated
@@ -712,14 +712,14 @@ def build_parser_create(self, subparsers, common_parser, mid_common_parser): | |||
There are two methods to read from stdin. Either specify ``-`` as path and | |||
pipe directly to borg:: | |||
|
|||
backup-vm --id myvm --stdout | borg create REPO::ARCHIVE - | |||
backup-vm --id myvm --stdout | borg create --repo /path/to/repo ARCHIVE - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason why you changed REPO to /path/to/repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you see my comment?
src/borg/archiver/create_cmd.py
Outdated
|
||
Or use ``--content-from-command`` to have Borg manage the execution of the | ||
command and piping. If you do so, the first PATH argument is interpreted | ||
as command to execute and any further arguments are treated as arguments | ||
to the command:: | ||
|
||
borg create --content-from-command REPO::ARCHIVE -- backup-vm --id myvm --stdout | ||
borg create --content-from-command --repo /path/to/repo ARCHIVE -- backup-vm --id myvm --stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you see my comment?
borgbackup -> /borgbackup
Dumbness re not being able to read comments in code resolved ... sorry for the inconvience |
REPO::ARCHIVE formatting has been replaced in the documentation with --repo
Only python files have been updated
All modified commands have been tested
This should replaces the initial PR