-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and use Brewfile #6052
Create and use Brewfile #6052
Conversation
Hmm, I am a bit torn about this. As long as the Brewfile contents is only used by ci.yml, I rather dislike having it in a separate file (and even a file in the already cluttered-too-much toplevel directory). But I've seen brew bundle can also receive input via a pipe, so maybe that solves this. |
only reason I lean towards including in the repo root is for macos developers, include |
Would you also update the docs for that? |
see ba8a36a |
https://github.com/borgbackup/borg/blob/master/docs/installation.rst#macos guess it rather should move to there? the normal user install is required for developers also, so we describe common steps there and only the dev specific stuff in the development section. |
@stephengroat did you see my last comment? also, it seem this branch needs a rebase on current master / conflict resolution. Sorry, but I had to update github CI for macOS because it recently got broken due to macOS fuse testing issues. |
ba8a36a
to
a256356
Compare
a256356
to
438f1dd
Compare
Rebased on current master, updated requirements, worked on docs. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6052 +/- ##
=======================================
Coverage 83.64% 83.65%
=======================================
Files 66 66
Lines 11867 11867
Branches 2151 2151
=======================================
+ Hits 9926 9927 +1
- Misses 1364 1365 +1
+ Partials 577 575 -2 ☔ View full report in Codecov by Sentry. |
From the macOS CI runner:
Thus, I'll remove the macFUSE/osxFUSE from the brewfile. It is not a strict requirement for borgbackup anyway as it is only used for borg mount. Some users may want it, some others might be uncomfortable with it as macFUSE uses kernel extensions. |
No description provided.