Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and use Brewfile #6052

Merged
merged 5 commits into from
Jan 14, 2024
Merged

Conversation

stephengroat
Copy link
Contributor

No description provided.

@ThomasWaldmann
Copy link
Member

Hmm, I am a bit torn about this.

As long as the Brewfile contents is only used by ci.yml, I rather dislike having it in a separate file (and even a file in the already cluttered-too-much toplevel directory).

But I've seen brew bundle can also receive input via a pipe, so maybe that solves this.

@stephengroat
Copy link
Contributor Author

only reason I lean towards including in the repo root is for macos developers, include brew bundle in the development instructions tends to make environment setup much easier

@ThomasWaldmann
Copy link
Member

Would you also update the docs for that?

@stephengroat
Copy link
Contributor Author

see ba8a36a

@ThomasWaldmann
Copy link
Member

https://github.com/borgbackup/borg/blob/master/docs/installation.rst#macos

guess it rather should move to there?

the normal user install is required for developers also, so we describe common steps there and only the dev specific stuff in the development section.

@ThomasWaldmann
Copy link
Member

@stephengroat did you see my last comment? also, it seem this branch needs a rebase on current master / conflict resolution.

Sorry, but I had to update github CI for macOS because it recently got broken due to macOS fuse testing issues.

@ThomasWaldmann
Copy link
Member

Rebased on current master, updated requirements, worked on docs.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (812eb35) 83.64% compared to head (08bb028) 83.65%.
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6052   +/-   ##
=======================================
  Coverage   83.64%   83.65%           
=======================================
  Files          66       66           
  Lines       11867    11867           
  Branches     2151     2151           
=======================================
+ Hits         9926     9927    +1     
- Misses       1364     1365    +1     
+ Partials      577      575    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann
Copy link
Member

From the macOS CI runner:

installer: Error - The FUSE for macOS installation package is not compatible with this version of macOS.

Thus, I'll remove the macFUSE/osxFUSE from the brewfile. It is not a strict requirement for borgbackup anyway as it is only used for borg mount. Some users may want it, some others might be uncomfortable with it as macFUSE uses kernel extensions.

@ThomasWaldmann ThomasWaldmann merged commit 2787da2 into borgbackup:master Jan 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants